Music Cleanups#1913
Merged
Merged
Conversation
Saw some cleanups while reviewing PR #1905 but I decided to make this separate. "Let Python be Python" -- move string concat in tests to use implicit. Fix a bug in ABC Parsing of ABCNote vs subclass ABCChord (order of attributes in parse were reversed -- was okay because they were called by keyword). Standardize ElementTree.fromstring as `EL` not `ET.fromstring` or `El`
|
Coverage is 93.057% — post-1905 into master. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw some cleanups while reviewing PR #1905 but I decided to make this separate.
"Let Python be Python" -- move string concat in tests to use implicit.
Fix a bug in ABC Parsing of ABCNote vs subclass ABCChord (order of attributes in parse were reversed -- was okay because they were called by keyword).
Standardize ElementTree.fromstring as
ELnotET.fromstringorEl